Update the order and default values in nifake metadata #2134
Conversation
rahulr-NI
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2134 +/- ##
==========================================
- Coverage 89.07% 81.72% -7.35%
==========================================
Files 71 29 -42
Lines 18960 4116 -14844
==========================================
- Hits 16889 3364 -13525
+ Misses 2071 752 -1319
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 46 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
rahulr-NI
changed the title
rahulr-NI
changed the title
rahulr-NI
requested review from
marcoskirsch and
ni-jfitzger
as code owners
| 'description': 'Aborts a previously initiated thingie.' | ||
| }, | ||
| 'included_in_proto': True, | ||
| 'included_in_proto': False, |
There was a problem hiding this comment.
Abort is such a common function that it's strange not to include in the example/fake/test metadata
There was a problem hiding this comment.
Yes.. Thats why I did not modify any portion of metadata that being generated from AzDo. We will need to create some stories to issues to make the necessary changes to Match AzDo version of metadata generated from AzDo to version present in GitHub. Which also should include the necessary test cases.
3 participants
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR updates the nimi-python repository metadata files with those from NI's private repository, resolves ordering issues, and addresses default values.
It contains new APIs generated during codegen but not present in nimi-python.
What testing has been done?
Tox build is failing here as in gRPC, the abort api in generated codes is not implemented but the existing test cases are expecting it.